Connect collectible overview page to backend #17884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (28)
|
vkjr
force-pushed
the
collectible-info
branch
4 times, most recently
from
a88c738
to
9d53230
Compare
vkjr
force-pushed
the
collectible-info
branch
from
9d53230
to
0bcb28f
Compare
J-Son89
reviewed
Nov 20, 2023
| @@ -82,4 +82,7 @@ | |||
| "wallet-owned-collectibles-filtering-done" {:fx [[:dispatch | |||
| [:wallet/owned-collectibles-filtering-done | |||
| event]]]} | |||
| "wallet-get-collectibles-details-done" {:fx [[:dispatch | |||
There was a problem hiding this comment.
will it be possible to move this file to status-im2 soon?
There was a problem hiding this comment.
Not sure, but anyway I'd rather make it a separate refactoring PR
J-Son89
reviewed
Nov 20, 2023
| @@ -4,17 +4,18 @@ | |||
| [react-native.core :as rn] | |||
| [status-im2.common.scroll-page.view :as scroll-page] | |||
| [status-im2.contexts.wallet.collectible.style :as style] | |||
| [status-im2.contexts.wallet.common.temp :as temp] | |||
J-Son89
reviewed
Nov 20, 2023
| [quo/collection-avatar {:image collection-image}] | ||
| [rn/view {:style style/collection-container} | ||
| [rn/view {:style style/collection-avatar-container} | ||
| [quo/collection-avatar {:image collection-image-url}]] |
There was a problem hiding this comment.
should we add a container-style prop to this component? e.g so it can be
[rn/view {:style style/collection-container}
[quo/collection-avatar {
:container-style style/collection-avatar-container
:image collection-image-url}]]
There was a problem hiding this comment.
collection-avatar inside doesn't have additional containers, only fast-image. Also so far it is used only here. So I'd postpone this change until we see that pattern of having external containers emerge.
J-Son89
reviewed
Nov 20, 2023
| [rn/flat-list | ||
| {:render-fn (fn [{:keys [trait-type value]}] | ||
| [rn/view {:style style/traits-item} | ||
| [quo/data-item |
There was a problem hiding this comment.
I think you can make use of container-style prop on data-item component
(fn [{:keys [trait-type value]}]
[quo/data-item
{:container-style style/traits-item
:description :default
:card? true
:status :default
...
it should already exist 👍
There was a problem hiding this comment.
@J-Son89, thanks, good point!
OmarBasem
reviewed
Nov 21, 2023
Comment on lines
+270
to
+281
| (rf/reg-event-fx :wallet/get-collectible-details | ||
| (fn [_ [collectible-id]] | ||
| (let [request-id 0 | ||
| collectible-id-converted (cske/transform-keys csk/->PascalCaseKeyword collectible-id) | ||
| request-params [request-id [collectible-id-converted]]] | ||
| {:json-rpc/call [{:method "wallet_getCollectiblesDetailsAsync" | ||
| :params request-params | ||
| :on-error (fn [error] | ||
| (log/error "failed to request collectible" | ||
| {:event :wallet/get-collectible-details | ||
| :error error | ||
| :params request-params}))}]}))) |
There was a problem hiding this comment.
Shouldn't the rpc-call has an :on-success ?
There was a problem hiding this comment.
@OmarBasem, this call doesn't return anything immediately, so I just omitted it. Meaningful results will come from signal later.
Also in the code of :json-rpc/call having :on-success is not obligatory, it goes under when clause:
(when on-success
(let [result (if js-response
(.-result response-js)
...
There was a problem hiding this comment.
this call doesn't return anything immediately
I am curious, so when the data finally arrives how is it being handled?
J-Son89
approved these changes
Nov 21, 2023
vkjr
force-pushed
the
collectible-info
branch
from
4ec6011
to
3d3b3b7
Compare
69% of end-end tests have passedFailed tests (10)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (31)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
30% of end-end tests have passedFailed tests (7)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (3)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
90% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (9)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
|
@vkjr failed e2e are not PR related. Ready for merge. |
yevh-berdnyk
pushed a commit
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17316
Summary
On the collectibles list page you can press any collectible and open its details
Figma designs: https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=1355-300904&mode=design&t=Upgum07x1OxZT1AP-4
Existing issues and Followups
Support traits on collectible info page (upgrade to new API) #17936
Traits aren't visible right now. They are supported in this status-go PR, but it crashes with current develop 😠
Support correct network displaying on collectible info page #17937
Network info doesn't work right now because
data-itemcomponent don't have configuration for icon when it is in:networkstateConnect account info on collectible info page to backend #17938
Account info doesn't work because when collectibles fetched for a bunch of addresses, backend doesn't add ownership address to collectible info
status: ready