Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick to release branch #20963

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Cherry pick to release branch #20963

merged 4 commits into from
Aug 6, 2024

Conversation

J-Son89
Copy link
Contributor

@J-Son89 J-Son89 commented Aug 6, 2024

Cherry picked the following work:

  1. chore(wallet): feature flag adding watch only accounts #20955 - disabling watch-only
  2. 📈 Capture onboarding funnel #20926 - more data for metrics
  3. fix(wallet): Fix input amount step skipped while sending a token #20852 - medium fix for wellet, nice-to-have
  4. enable status proxy #20931 - ready to be merged, contains status-go

This also bumps status-go to latest on release branch.

* chore(wallet): feature flag adding watch only accounts

* e2e: disabled test for watch-only accounts

---------

Co-authored-by: Yevheniia Berdnyk <ie.berdnyk@gmail.com>
@J-Son89 J-Son89 requested a review from churik as a code owner August 6, 2024 11:27
@J-Son89 J-Son89 requested review from ilmotta and removed request for churik August 6, 2024 11:27
@J-Son89 J-Son89 self-assigned this Aug 6, 2024
@J-Son89 J-Son89 requested a review from churik August 6, 2024 11:27
@status-im-auto
Copy link
Member

status-im-auto commented Aug 6, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9d3a264 #1 2024-08-06 11:32:44 ~5 min tests 📄log
✔️ 9d3a264 #1 2024-08-06 11:36:33 ~8 min android-e2e 🤖apk 📲
✔️ 9d3a264 #1 2024-08-06 11:37:00 ~9 min android 🤖apk 📲
✔️ 9d3a264 #1 2024-08-06 11:39:11 ~11 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 624babc #2 2024-08-06 11:49:21 ~5 min tests 📄log
✔️ 624babc #2 2024-08-06 11:51:59 ~7 min android-e2e 🤖apk 📲
✔️ 624babc #2 2024-08-06 11:52:23 ~8 min android 🤖apk 📲
✔️ 624babc #2 2024-08-06 11:54:26 ~10 min ios 📱ipa 📲
✔️ 612805b #3 2024-08-06 14:25:50 ~5 min tests 📄log
✔️ 612805b #3 2024-08-06 14:28:31 ~8 min android-e2e 🤖apk 📲
✔️ 612805b #3 2024-08-06 14:28:41 ~8 min android 🤖apk 📲

J-Son89 and others added 3 commits August 6, 2024 12:43
* 📈 Capture onboarding funnel

* ⏩ Faster lookup

* ✅ Capture how many people enabled metrics

- It technically captures disabled too
- But we'll never know if someone disabled
- Because that info won't be transmitted

* ✏️ Fix tests

* 🧯 Fix lint
)

* fix(wallet): Fix input amount step skipped while sending a token

* Add comment about ^:flush-dom metadata
@J-Son89 J-Son89 changed the title chore(wallet): feature flag adding watch only accounts (#20955) Cherry pick to release branch Aug 6, 2024
@J-Son89 J-Son89 merged commit 2547179 into release/2.30.x Aug 6, 2024
4 of 5 checks passed
@J-Son89 J-Son89 deleted the jc/fix branch August 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants