-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for multiple icon sets through subpath exports #579
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 9cbd8e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
we will have to fix the monorepo to publish it, won't we? |
Worth checking if addresses #466 completely and if it could be closed by this. |
What do you mean by this? |
Other packages have type-checking errors. |
Would it makes sense to add network's icons? It would make my life easier since these are part of portfolio and are used as icons in dropdown menu. |
yeah definitely, but they don't seem to be in SVG format for some reason |
Previously, we only synced the 20px variant of icons and allowed scaling down to 16px and 12px using a prop. Later, we discovered that some icons look different when they are smaller.
This PR introduces multi-entry bundling and exports for:
import {} from '@status-im/icons/20
import {} from '@status-im/icons/16
import {} from '@status-im/icons/12
import {} from '@status-im/icons/social
import {} from '@status-im/icons/reactions
This required changes in the file structure, Vite's bundling config, and package.json
exports.
I also removed Tamagui from the icon's template, thus removing runtime and making them fully static. The default is
currentColor
, which is usual for web-specific icons.I made it work with the rest of the monorepo but decided not to include changes in this PR – it requires an upgrade of vite and typescript.
Added p-map to run generation concurrently, speeding up the Figma sync drastically.