Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blas/base/dtrmv #2540

Merged
merged 16 commits into from
Aug 1, 2024
Merged

feat: add blas/base/dtrmv #2540

merged 16 commits into from
Aug 1, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Jul 9, 2024

Progresses #2039.

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to perform one of the matrix-vector operations x = A*x, or x = A**T*x, where x is an N element vector, and A is an N by N unit, or non-unit, upper or lower triangular matrix as defined in BLAS Level 2 routines. Specifically adding @stdlib/blas/base/dtrmv is proposed.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 9, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Jul 9, 2024
@kgryte
Copy link
Member

kgryte commented Jul 9, 2024

In addition to the changes discussed on #2535, you'll want to check the box in your PR description. :)

@aman-095 aman-095 mentioned this pull request Jul 11, 2024
1 task
@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Jul 11, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jul 11, 2024
@kgryte
Copy link
Member

kgryte commented Jul 14, 2024

This PR will need similar ndarray updates as discussed and implemented in #2535.

@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Jul 30, 2024
@kgryte
Copy link
Member

kgryte commented Aug 1, 2024

@aman-095 Would you mind porting over the changes from #2535 to this PR? Thanks!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 1, 2024
@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Aug 1, 2024
@kgryte kgryte removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Aug 1, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte merged commit 640278b into stdlib-js:develop Aug 1, 2024
12 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2540
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants