update polyfill with better native ES6 Promise test

[lvscar]

Object.prototype.toString.call(Promise.resolve()) === '[object Promise]'   

not works in Chrome

[stefanpenner]

Cc @jakearchibald

[stefanpenner]

i am unsure if we actually support those old/intermediate experimental version?

[stefanpenner]

not works in Chrome

yes but this is a chrome bug, but it is fixed in canary and should be available in stable soon:

As such, I don't believe we need this PR. As the existing check should cover these additional cases, and the buggy version of chrome without [object Promise] will age out soon thanks to its evergreen and auto-updating behaving.

[yethee]

Why this condition !P.cast?

[piranna]

As such, I don't believe we need this PR. As the existing check should cover these additional cases, and the buggy version of chrome without [object Promise] will age out soon thanks to its evergreen and auto-updating behaving.

You are right, but with current versions of both Chrome and Node.js (v0.12.2, latest stable) is not working (and the v8 update cycle of Node.js is not so fast as the one of Chrome), and also the checking mechanism of this pull-reques is more robust. I think this pull-request definitely needs to be merged.

[bradobro]

Seems to me P.resolve().constructor.name === "Promise" is a more resilient test in the current browser climate.

[stefanpenner]

As such, I don't believe we need this PR. As the existing check should cover these additional cases, and the buggy version of chrome without [object Promise] will age out soon thanks to its evergreen and auto-updating behaving.

[piranna]

Why clossing this without merge? The current behaviour don't use native Promises on Node.js or Io.js.

[stefanpenner]

#99 (comment)

[piranna]

#99 (comment)

What this means? It only talk about Chrome, not Node.js... It's true both are based on v8, but Node.js and Io.js will probably not update it to the current version until at least 1 more year...

[stefanpenner]

Io.js will probably not update it to the
current version until at least 1 more year...

This doesn't seem correct, see: nodejs/node#1639 as such I believe iojs isn't nearly that far behind.

[piranna]

Io.js will probably not update it to the
current version until at least 1 more year...

This doesn't seem correct, see: nodejs/node#1639 I believe iojs isn't nearly a full year behind.

But Node.js is...

[stefanpenner]

But Node.js is...

then those users can continue to use a fully functional polyfil, that is compliant (and significantly faster)

[piranna]

But Node.js is...
then those users can continue to use a fully functional polyfil, that is compliant (and significantly faster)

For example? The only one fully compliant seems to be this one... I don't know why Node.js users need to use a polyfill having native ones... We are using this in production grade products...

[stefanpenner]

It has also come to my attention that v8 promises still have some bugs. (Recently discovered) So the strictness here is guarding us from those issues.

[dmitrykuznetsovdev]

Why this condition !P.cast?
safari not working.
wild brakes 👎 - D
Memory is growing very strongly