Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused local variable inside Factories #111

Closed
dlemures opened this issue Jun 27, 2016 · 3 comments
Closed

Unused local variable inside Factories #111

dlemures opened this issue Jun 27, 2016 · 3 comments
Assignees
Milestone

Comments

@dlemures
Copy link
Collaborator

Unused local variable inside Factories that can make CI findbug hooks complain:

public AndroidAccountIntents createInstance(Scope scope) {
     scope = getTargetScope(scope);
     AndroidAccountIntents androidAccountIntents = new AndroidAccountIntents();
     return androidAccountIntents;
}

Only happens when scope is not used. Can we avoid that?

@dlemures dlemures added this to the 1.0.0-RC4 milestone Jun 27, 2016
@dpreussler
Copy link

for documentation: this is how to suppress for now:

<Match>
    <!-- AUTO-GENERATED FILE -->
    <Class name="~.*\$\$Factory" />
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
</Match>

@stephanenicolas
Copy link
Owner

Thx for the workaround @dpreussler, but we are gonna fix this.

@stephanenicolas
Copy link
Owner

Will be part of RC10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants