fix: close server stream on observer unsubscribe #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinschuldt
changed the title
|
Thanks @justinschuldt ! |
stephenh
pushed a commit
that referenced
this pull request
Jun 13, 2021
## [1.81.3](v1.81.2...v1.81.3) (2021-06-13) ### Bug Fixes * close server stream on observer unsubscribe ([#309](#309)) ([4b72563](4b72563))
|
🎉 This PR is included in version 1.81.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that once a server stream is opened, there is no way to close it. Unsubscribing from the observable would not close the connection between the browser and the server.
This change adds a handler on the observer that will call the grpc.invoke's
close, which will close the connection between the browser and the server.