Avoid unnecessary string allocations in Get/SetMsQuicParameter (dotne…

…t#89050)
stephentoub · Jul 18, 2023 · 4f933e1 · 4f933e1
1 parent d1ef9b6
commit 4f933e1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs b/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs
@@ -67,7 +67,11 @@ internal static unsafe T GetMsQuicParameter<T>(MsQuicSafeHandle handle, uint par
             &length,
             (byte*)&value);
 
-        ThrowHelper.ThrowIfMsQuicError(status, $"GetParam({handle}, {parameter}) failed");
+        if (StatusFailed(status))
+        {
+            ThrowHelper.ThrowMsQuicException(status, $"GetParam({handle}, {parameter}) failed");
+        }
+
         return value;
     }
 
@@ -80,6 +84,9 @@ internal static unsafe void SetMsQuicParameter<T>(MsQuicSafeHandle handle, uint
             (uint)sizeof(T),
             (byte*)&value);
 
-        ThrowHelper.ThrowIfMsQuicError(status, $"SetParam({handle}, {parameter}) failed");
+        if (StatusFailed(status))
+        {
+            ThrowHelper.ThrowMsQuicException(status, $"SetParam({handle}, {parameter}) failed");
+        }
     }
 }
diff --git a/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs b/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ThrowHelper.cs
@@ -130,10 +130,15 @@ internal static void ThrowIfMsQuicError(int status, string? message = null)
     {
         if (StatusFailed(status))
         {
-            throw GetExceptionForMsQuicStatus(status, message: message);
+            ThrowMsQuicException(status, message);
         }
     }
 
+    internal static void ThrowMsQuicException(int status, string? message = null)
+    {
+        throw GetExceptionForMsQuicStatus(status, message: message);
+    }
+
     internal static string GetErrorMessageForStatus(int status, string? message)
     {
         return (message ?? "Status code") + ": " + GetErrorMessageForStatus(status);