Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StaticArrays usage #27

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Improve StaticArrays usage #27

merged 2 commits into from
Mar 21, 2018

Conversation

wsshin
Copy link
Collaborator

@wsshin wsshin commented Mar 21, 2018

This PR makes a few improvements on the usage of StaticArrays:

  • Halve the size of signmatrix to work around StaticArrays Issue #384.
  • Simplify some expressions by taking advantage of StaticArrays PR #274 on broadcast.

@codecov-io
Copy link

codecov-io commented Mar 21, 2018

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files           7        7           
  Lines         223      223           
=======================================
  Hits          209      209           
  Misses         14       14
Impacted Files Coverage Δ
src/ellipsoid.jl 100% <ø> (ø) ⬆️
src/box.jl 93.75% <60%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211ec40...1f6b786. Read the comment docs.

@stevengj stevengj merged commit dbb9880 into stevengj:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants