Fix Cargo features used by docs.rs #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the required features for building were missing. To avoid this in the future, specified an MCU feature for a random (read: the one I'm using) concrete MCU instead.
hannobraun
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Thank you for the pull request, @dbrgn! Looks good.
I think we'll have to put out a new release to re-trigger the docs.rs build. I think that's reasonable. We just have to be careful about the version. Not sure, if the recent changes were non-breaking, so we might have to release 0.9.0, or backport this change to a 0.8.x release branch and release 0.8.1.
I'm fine with either option.
This was referenced Dec 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs.rs build currently fails: https://docs.rs/crate/stm32l0xx-hal/0.8.0/builds/458082 Some of the required features for building were missing.
To avoid this in the future, specified an MCU feature for a random (read: the one I'm using) concrete MCU instead.
Can we re-trigger the building of the docs without creating a new release? Probably not, right? Should we create a 0.8.1 release to fix the docs? (I could do that.)