Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cortex-m-semihosting a dev dependency #208

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Make cortex-m-semihosting a dev dependency #208

merged 1 commit into from
Dec 10, 2021

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Dec 9, 2021

It's not actually used anywhere except in examples.

(Would be nice if we could get this into the 0.9 release #207 as well.)

@dbrgn dbrgn added the enhancement New feature or request label Dec 9, 2021
@dbrgn dbrgn requested a review from a team December 9, 2021 22:50
@dbrgn dbrgn removed the enhancement New feature or request label Dec 9, 2021
hannobraun
hannobraun approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dbrgn! Looks good to me!

@hannobraun hannobraun merged commit 89866bc into master Dec 10, 2021
@hannobraun hannobraun deleted the semihosting branch December 10, 2021 11:39
@hannobraun
Copy link
Contributor

Would be even better, if we left semihosting behind completely, but oh well 😁

@hannobraun hannobraun mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrgn @hannobraun