Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Add call for maintainers #212

Merged
merged 1 commit into from
Jan 13, 2022
Merged

README: Add call for maintainers #212

merged 1 commit into from
Jan 13, 2022

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Jan 13, 2022 •
edited
Loading

I guess that should do. What do you think, @jamwaffles?

Closes #211.

@dbrgn dbrgn requested a review from jamwaffles January 13, 2022 14:20
@dbrgn dbrgn requested a review from a team as a code owner January 13, 2022 14:20
@dbrgn
Copy link
Contributor Author

dbrgn commented Jan 13, 2022 •
edited
Loading

By the way, so far our workflow was:

  • External contributions can be approved and merged by one of the maintainers
  • PRs by maintainers can be reviewed/approved by another maintainer (unless trivial), but are merged by the submitter

Do you think that makes sense?

jamwaffles
jamwaffles approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good!

Do you think that makes sense?

Yep, that's how I like to work as well :)

@dbrgn dbrgn merged commit 5e0d194 into master Jan 13, 2022
@dbrgn dbrgn deleted the maintainers-wanted branch January 13, 2022 16:09
@dbrgn dbrgn mentioned this pull request Jan 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamwaffles jamwaffles jamwaffles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stepping down as a maintainer
2 participants
@dbrgn @jamwaffles