Enable all output pins for TIM2 on all devices #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
correct-tim2-pins
branch
2 times, most recently
from
3a1aba9
to
8240858
Compare
Looking through some ST datasheets/RMs, TIM2 can output on the pins changed in this PR from the x011 range all the way up to the largest chips in the L0 family.
jamwaffles
force-pushed
the
correct-tim2-pins
branch
from
8240858
to
8719193
Compare
dbrgn
approved these changes
Jan 15, 2023
|
Thanks for the review! I've been spot checking a few different datasheets and found (and fixed) a bug so I think we're ok 🤞. Waiting for testing in #219 before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through some ST datasheets/RMs, TIM2 can output on the pins changed in this PR from the x011 range all the way up to the largest chips in the L0 family.
Closes #219