make ServiceStats an intrinsic #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgerstmayr
commented
Apr 23, 2024
andreasgerstmayr
commented
- make ServiceStats an intrinsic
- skip allocating ServiceStats in rebatchIterator if already allocated
- clone ServiceStats in Spanset.clone()
* make ServiceStats an intrinsic * skip allocating ServiceStats in rebatchIterator if already allocated * clone ServiceStats in Spanset.clone() Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
pkg/traceql/storage.go
Outdated
| @@ -175,6 +172,7 @@ func (s *Spanset) Release() { | |||
|
|
|||
| func (s *Spanset) clone() *Spanset { | |||
| ss := *s | |||
| ss.ServiceStats = maps.Clone(s.ServiceStats) | |||
There was a problem hiding this comment.
not 100% sure if a deep clone is required here
There was a problem hiding this comment.
The SpanSet also contains the other data structures like Attributes []*SpansetAttribute and Spans []Span. Both are passed to ss without creating a deep clone first. I think it would be more consistent to do the same for ServiceStats.
I also checked all the parts where s.clone() is called and it does not look like a deep clone is required here
There was a problem hiding this comment.
Thanks for checking! I removed the maps.Clone().
3 tasks
stoewer
reviewed
Apr 26, 2024
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.