Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ivy UseStoreon hook #21

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Conversation

valburyakov
Copy link
Contributor

#15

Example of using Storeon with Ivy

@irustm
Copy link
Member

irustm commented Jul 11, 2019

Hey! Thanks for this PR.
please fix size-limit:

Size limit: 533 B
Package size: 536 B

@irustm
Copy link
Member

irustm commented Jul 11, 2019

and I think these hooks should go with the next tag.

@valburyakov
Copy link
Contributor Author

and I think these hooks should go with the next tag.

you mean publish lib with @next tag ?

@irustm
Copy link
Member

irustm commented Jul 11, 2019

I guess yeah, just need to update the demos, and write in readme that it's all an experiment

@irustm irustm merged commit 3f9a1a2 into storeon:master Jul 11, 2019
@irustm irustm mentioned this pull request Jul 11, 2019
@Svetomechc
Copy link
Contributor

So, this PR also makes it impossible to use @storeon/angular without Ivy as I understand? Just making sure that this was intended, @valburyakov?

I mean, even just using the service, not Ivy hooks, fails (in production mode, debug is fine):
image

@valburyakov
Copy link
Contributor Author

@Svetomechc You mean that even when you don't use ivy hook decorator prod build is failed with storeon ? If yes - that seems an issue.

@Svetomechc
Copy link
Contributor

Svetomechc commented Jul 18, 2019

@valburyakov it builds fine but errors at runtime,
UPD: Nevermind, I think the error is caused by something in my local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants