-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose style for customisation #2370
Conversation
Thanks, totally makes sense. Can you please do the same in rest of the places in this component? |
Codecov Report
@@ Coverage Diff @@
## master #2370 +/- ##
=======================================
Coverage 19.92% 19.92%
=======================================
Files 293 293
Lines 6484 6484
Branches 754 768 +14
=======================================
Hits 1292 1292
+ Misses 4625 4592 -33
- Partials 567 600 +33
Continue to review full report at Codecov.
|
@Hypnosphi 👍 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again
Issue:
What I did
Cannot modify
button.topRight
style from storybook config.jsexample:
How to test
Is this testable with jest or storyshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.