Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous vertical scrollbar in fullscreen #2394

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

pelotom
Copy link
Contributor

@pelotom pelotom commented Nov 29, 2017

Fixes #2348.

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #2394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2394   +/-   ##
=======================================
  Coverage   19.92%   19.92%           
=======================================
  Files         293      293           
  Lines        6485     6485           
  Branches      763      753   -10     
=======================================
  Hits         1292     1292           
- Misses       4599     4620   +21     
+ Partials      594      573   -21
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/layout/index.js 78.43% <ø> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 25.71% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7660d...4e78b8d. Read the comment docs.

@ndelangen ndelangen merged commit b157cae into storybookjs:master Nov 29, 2017
@ndelangen ndelangen added the bug label Nov 29, 2017
@ndelangen
Copy link
Member

Thanks @pelotom !

@pelotom pelotom deleted the fix-#2348 branch November 29, 2017 08:00
@pelotom
Copy link
Contributor Author

pelotom commented Nov 29, 2017

Thanks for the fast merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants