fix tests not actually running #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/3.3 #2450 +/- ##
===============================================
+ Coverage 19.15% 19.18% +0.02%
===============================================
Files 355 355
Lines 8252 8253 +1
Branches 912 913 +1
===============================================
+ Hits 1581 1583 +2
+ Misses 5958 5949 -9
- Partials 713 721 +8
Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: I broke
multiSnapshotWithOptionstesting (including of storybook itself) with my PR #2417What I did
The tests weren't actually running because of the refactor to call through to
snapshotWithOptions. Once I fixed that, I found that theunmountcall I added wasn't always available. So I put a guard on that. Maybe someone who understands how that should be unmounted better can take a look.Because tests haven't been passing incorrectly, some bugs may have slipped into the branch. I fixed a few easy-update snapshots but there remain two failures which I'm still looking into.