fix missing supported extension check in case when asset is a string #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've came across this inconsistent logic while investigating my own issue: storybookjs#2363
danielduan
reviewed
Dec 12, 2017
app/vue/src/server/iframe.html.js
Outdated
| @@ -29,7 +29,9 @@ const urlsFromAssets = assets => { | |||
| .forEach(key => { | |||
| let asset = assets[key]; | |||
| if (typeof asset === 'string') { | |||
| urls[getExtensionForFilename(asset)].push(asset); | |||
| if (Boolean(urls[getExtensionForFilename(asset)])) { | |||
There was a problem hiding this comment.
This is fine but we usually just do !!(urls[getExtensionForFilename(asset)]) to convert into boolean
There was a problem hiding this comment.
Oh, I copied it from few lines below. But actually it can be simplified to just if (urls[getExtensionForFilename(asset)]) { ... } - otherwise CircleCI test fails at no-extra-boolean-cast rule.
Codecov Report
@@ Coverage Diff @@
## master #2468 +/- ##
=======================================
Coverage 16.87% 16.87%
=======================================
Files 307 307
Lines 7792 7792
Branches 785 779 -6
=======================================
Hits 1315 1315
- Misses 5819 5843 +24
+ Partials 658 634 -24
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've came across this inconsistent logic while investigating my own issue: #2363
There is a check in case of an Object, but there is none in case of String. This might lead to hardly explainable errors.
What I did
I've added the missing check.
How to test
See the issue.
Is this testable with jest or storyshots?
Yes.
Does this need a new example in the kitchen sink apps?
No.
Does this need an update to the documentation?
No.