Tags: Refine composition behavior #27379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 243d5f1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
valentinpalkovic
approved these changes
May 27, 2024
storybook-bot
pushed a commit
that referenced
this pull request
May 27, 2024
…tags Tags: Refine composition behavior (cherry picked from commit 8596408)
Merged
7 tasks
storybook-bot
pushed a commit
that referenced
this pull request
May 27, 2024
…tags Tags: Refine composition behavior (cherry picked from commit 8596408)
9 tasks
storybook-bot
pushed a commit
that referenced
this pull request
May 27, 2024
…tags Tags: Refine composition behavior (cherry picked from commit 8596408)
storybook-bot
pushed a commit
that referenced
this pull request
May 28, 2024
…tags Tags: Refine composition behavior (cherry picked from commit 8596408)
storybook-bot
pushed a commit
that referenced
this pull request
May 29, 2024
…tags Tags: Refine composition behavior (cherry picked from commit 8596408)
storybook-bot
pushed a commit
that referenced
this pull request
May 29, 2024
…tags Tags: Refine composition behavior (cherry picked from commit 8596408)
storybook-bot
pushed a commit
that referenced
this pull request
May 29, 2024
…tags Tags: Refine composition behavior (cherry picked from commit 8596408)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
In #27358 I fixed a glaring composition bug between 8.1+ storybooks and older Storybook versions that did not have the
devtag automatically added to all stories.This PR improves upon that PR:
devtag to the front of the list, which is the correct precedencetesttag. This shouldn't really change anything right now since the Test Runner ignores composition, but could prevent future bugs if we change thetesttag behavior in the future.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>