Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Remove external overrides #28632

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Components: Remove external overrides #28632

merged 1 commit into from
Jul 17, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jul 17, 2024

Closes #28619

What I did

Remove external overrides, use package.json as source of truth

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.5 MB 216 B 1.67 0%
initSize 198 MB 198 MB 1.39 kB -0.7 0%
diffSize 121 MB 121 MB 1.17 kB -0.71 0%
buildSize 7.59 MB 7.59 MB 48 B 9.1 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 3 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 4.36 0%
buildSbPreviewSize 349 kB 349 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 3.06 0%
buildPreviewSize 3.12 MB 3.12 MB 48 B Infinity 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 13.4s 13.3s -149ms -0.07 -1.1%
generateTime 22.3s 21.9s -385ms -0.26 -1.8%
initTime 24.8s 22.8s -2s -30ms -0.34 -8.9%
buildTime 15.6s 14s -1s -544ms -0.17 -11%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8.9s 9.5s 620ms 1.41 🔺6.5%
devManagerResponsive 5.9s 6.1s 200ms 1.39 3.3%
devManagerHeaderVisible 888ms 796ms -92ms -0.12 -11.6%
devManagerIndexVisible 916ms 834ms -82ms 0.02 -9.8%
devStoryVisibleUncached 1.2s 1.6s 438ms 1.74 🔺26%
devStoryVisible 933ms 856ms -77ms -0.01 -9%
devAutodocsVisible 848ms 843ms -5ms 1.83 -0.6%
devMDXVisible 848ms 772ms -76ms 0.46 -9.8%
buildManagerHeaderVisible 944ms 832ms -112ms 0.41 -13.5%
buildManagerIndexVisible 954ms 839ms -115ms 0.44 -13.7%
buildStoryVisible 1s 900ms -103ms 0.57 -11.4%
buildAutodocsVisible 987ms 706ms -281ms -0.19 -39.8%
buildMDXVisible 842ms 668ms -174ms -0.14 -26%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Modified dependencies for src/components/index.ts entry in /code/core/scripts/entries.ts
  • Removed '@storybook/csf' and '@storybook/global' dependencies
  • Entry now includes only 'react' and 'react-dom'
  • Aligns with goal to remove external overrides and use package.json as source of truth

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f00dec5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen merged commit bd7c2b7 into next Jul 17, 2024
53 of 60 checks passed
@kasperpeulen kasperpeulen deleted the kasper/externals branch July 17, 2024 13:22
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
12 tasks
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 19, 2024
@shilman shilman changed the title Build: Remove external overrides, use package.json as source of truth Components: Remove external overrides Jul 19, 2024
shilman pushed a commit that referenced this pull request Jul 19, 2024
Build: Remove external overrides, use package.json as source of truth
(cherry picked from commit bd7c2b7)
@shilman shilman mentioned this pull request Jul 19, 2024
13 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/core is (wrongly) specifying @storybook/global as a devDependency
3 participants