Version 3 of flake8 contains breaking changes, so pin requirement.

[donkirkby]

To see the problem, clear out your tox cache and rebuild.

rm -rf .tox
tox

I got a bunch of errors hinting at flake8, and I found that flake8 version 3 has some breaking changes. This change just pins the requirement at the version you probably used when you first set up pytest-flake8.

[codecov-io]

Current coverage is 98.96% (diff: 100%)

Merging #13 into master will not change coverage

@@             master        #13   diff @@
==========================================
  Files             5          5          
  Lines           290        290          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            287        287          
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update a8954a3...ac67551

[stphivos]

Hi Don,

I found that also upgrading the following from:

pytest==2.8.2
pytest-cov==2.2.0
pytest-flake8==0.2

to

pytest==3.0.3
pytest-cov==2.4.0
pytest-flake8==0.7

also works. I also needed to update tox.ini setting flake8-ignore = *.py F403 F405 to allow for this "violation":

F405    name may be undefined, or defined from star imports: module

I tested using rm -rf .tox/ && find . -name "*.pyc" -delete && rm -rf .cache/ && tox.

Do you see any benefit in keeping the older versions with flake8==2.5.4?

Thanks!

[donkirkby]

Upgrading to a newer version of pytest sounds fine to me, but I would consider pinning the version of dependencies like flake8. You can use pip freeze to dump all the current packages from a virtualenv like one of the ones created by tox.

[stphivos]

Sounds good, I added pip-tools to be able to maintain both explicit and implicit pinned dependencies: #15