Skipfieldfix

[donkirkby]

Move SkipField import out of constants.

Stops MockSet from requiring Django to be configured.

Here's an example of the problem. Before you added SkipField to constants.py, I could write a simple script that used MockSet.

from django_mock_queries.query import MockSet

print('Hello.')

Now if I do that, I get this error:

Traceback (most recent call last):
  File "/mnt/data/don/workspace/scratch/scratch.py", line 1, in <module>
    from django_mock_queries.query import MockSet
  File "/mnt/data/don/git/django-mock-queries/django_mock_queries/query.py", line 4, in <module>
    from .constants import *
  File "/mnt/data/don/git/django-mock-queries/django_mock_queries/constants.py", line 50, in <module>
    SkipField = locate('rest_framework.fields.SkipField')
  File "/usr/lib/python2.7/pydoc.py", line 1520, in locate
    nextmodule = safeimport(join(parts[:n+1], '.'), forceload)
  File "/usr/lib/python2.7/pydoc.py", line 342, in safeimport
    raise ErrorDuringImport(path, sys.exc_info())
pydoc.ErrorDuringImport: problem in rest_framework.fields - <class 'django.core.exceptions.ImproperlyConfigured'>: Requested setting DEFAULT_INDEX_TABLESPACE, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.

I don't know if this is the best solution, but SkipField is only used in asserts.py. This pull request includes the other one for flake8.

By the way, how are you supposed to use assert_serializer? I couldn't see an example.

[codecov-io]

Current coverage is 98.96% (diff: 100%)

Merging #14 into master will not change coverage

@@             master        #14   diff @@
==========================================
  Files             5          5          
  Lines           290        290          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            287        287          
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update a8954a3...86f8396

[stphivos]

Yes I think it's a good idea. Merging this now and in case the flake8 related requirements need to be updated we can overwrite the first commit afterwards.

There is an example of assert_serializer in the README: https://github.com/stphivos/django-mock-queries#test-django-rest-framework-model-serializer. But yes, the repo could use some real docs. :)

Thanks!

[donkirkby]

Thanks, I didn't see it in the README.