You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
lxml wheels for Python 3.12 are not available yet though, and building lxml from the 4.9.2 sdist published on PyPI (latest stable release) results in an error. See down below...
This error has been fixed on their master branch, but they also bumped the major version. This means that once Python 3.12 gets released, Streamlink will have to lift the <5 version constraint of lxml:
I'm fine with this. Since we have no statistical data to say who is using what I don't see any reason to inconvenience or hold back development for the sake of supporting older releases. People will have to upgrade.
There's nothing to agree about. This thread is a simple note (for myself) to not forget to bump lxml's upper version constraint once py312 enters beta. Simple dependency management... lxml 4.x still is and will be fine on <=py311. No one has to upgrade anything here. The only thing relevant for Streamlink is checking whether there will be other incompabilities in lxml's 5.0.0 release which need changes here.
The first beta release of Python 3.12 will be out on 2023-05-22:
https://peps.python.org/pep-0693/
lxml
wheels for Python 3.12 are not available yet though, and buildinglxml
from the4.9.2
sdist published on PyPI (latest stable release) results in an error. See down below...This error has been fixed on their master branch, but they also bumped the major version. This means that once Python 3.12 gets released, Streamlink will have to lift the
<5
version constraint oflxml
:streamlink/setup.cfg
Line 45 in 15fbab1
lxml's 5.0.0 changelog so far:
https://github.com/lxml/lxml/blob/master/CHANGES.txt
Building from the 4.9.2 sdist fails, regardless the installed
cython
version, as the build process ignores it:Building from git (
lxml-4.9.2
ormaster
) works when the rightcython
version is installed:However, when
cython <0.29.34
is installed, this results in the same error as above:The text was updated successfully, but these errors were encountered: