Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lxml version for py3.12 E2E tests #18637

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Sep 20, 2024

What does this PR do?

This PR bumps lxml version to 5.1.1.

Motivation

IBM WAS was failing when testing the py3.12 Agent build with lxml==4.9.4. In the environment on Linux we see the follow error when running the manual check in debug mode - datadog-agent check ibm_was -l debug

2024-09-20 17:39:10 UTC | CORE | DEBUG | (pkg/collector/python/loader.go:162 in Load) | Unable to load python module - datadog_checks.ibm_was: unable to import module 'datadog_checks.ibm_was': Traceback (most recent call last):
  File "/opt/datadog-agent/embedded/lib/python3.12/site-packages/datadog_checks/ibm_was/__init__.py", line 5, in <module>
    from .ibm_was import IbmWasCheck
  File "/opt/datadog-agent/embedded/lib/python3.12/site-packages/datadog_checks/ibm_was/ibm_was.py", line 7, in <module>
    from lxml import etree
ImportError: /opt/datadog-agent/embedded/lib/python3.12/site-packages/lxml/etree.cpython-312-x86_64-linux-gnu.so: undefined symbol: xsltGetProfileInformation

Additional Notes

These two issues seem to suggest we can't build lxml with CPython3.12

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (8da9ca8) to head (3b0a8f4).
Report is 11 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ibm_was 96.06% <ø> (+0.03%) ⬆️
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 71.21% <ø> (-13.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale changed the title Kyleneale/bump lxml version Bump lxml version for py3.12 E2E tests Sep 20, 2024
@Kyle-Neale Kyle-Neale marked this pull request as ready for review September 20, 2024 23:32
@Kyle-Neale Kyle-Neale requested review from a team as code owners September 20, 2024 23:32
amw-zero added a commit to DataDog/datadog-agent that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant