Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect result for obj.Value().MSI() getter #65

Merged
merged 11 commits into from
May 27, 2018
Merged

Fixed incorrect result for obj.Value().MSI() getter #65

merged 11 commits into from
May 27, 2018

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented Apr 9, 2018

When an object is created as obj := objx.Map{...}
calling obj.Value().MSI() returns an empty map. It should return the object itself as map[string]interface{} instead

@hanzei hanzei self-requested a review April 9, 2018 15:55
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @earncef!
Your solution kind of fixes the problem but is a bit hacky because type_specific_codegen.go is an auto generated file. But this is fine.

type_specific_codegen.go Show resolved Hide resolved
type_specific_codegen_test.go Outdated Show resolved Hide resolved
@geseq
Copy link
Collaborator Author

geseq commented May 26, 2018

I will also try and work on a better solution for the type_specific_codegen.go file

@hanzei
Copy link
Collaborator

hanzei commented May 27, 2018

I opened #70. You might want to look into this

@hanzei hanzei added this to the v0.2 milestone May 27, 2018
@hanzei hanzei merged commit a97c7cc into stretchr:master May 27, 2018
@hanzei hanzei self-assigned this May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants