Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tests for type_specific.go and fixed code #75

Merged
merged 2 commits into from
May 31, 2018
Merged

New tests for type_specific.go and fixed code #75

merged 2 commits into from
May 31, 2018

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented May 28, 2018

There was some code in type_specific.go:ObjxMapSlice() (migrated from the original type_specific_codegen.go) which seemed to be for the purpose of converting []interface{Map...} to []Map, but contained no tests and didn't work for []MSI or []interface{MSI...}

Fixed, and added tests.

@hanzei hanzei self-requested a review May 31, 2018 18:33
@hanzei hanzei self-assigned this May 31, 2018
@hanzei hanzei added this to the v0.2 milestone May 31, 2018
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei
Copy link
Collaborator

hanzei commented May 31, 2018

@earncef Could you please run gofmt -w -s *.go to fix some code formating

@hanzei hanzei merged commit 0ab728f into stretchr:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants