Change CI workflow triggers to pull_request #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwright-stripe
force-pushed
the
jwright/update-workflow-target
branch
from
41d8f1e
to
6733e40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
pull_request_targetfrom the GitHub Action workflow triggers.Right now, by using
pull_request_target, the workflow executes off the targeted branch. That is, if we got a PR that's trying to merge code intomain, then the CI tests would actually run off the existingmainbranch, which isn't what we want!But we also can't easily use a different trigger like
pull_request. The issue is that these CI checks are meant to run end-to-end tests, making live requests using a dedicated Stripe test account. And secrets (reasonably!) aren't available to pull requests from forked repositories.In terms of benefit/risks tradeoffs, we decided that the preferred option is to just run these tests on pushes to the main branch. We have this today, so the only change to make here was to remove the
pull_request_targettrigger.In the process, I also updated our
pushtrigger to filter on the relevant paths to prevent unnecessary workflows from being executed.Rollout plan
After we merge this in, let's go have Dependabot rebase all the existing PR's / branches so everything is up-to-date.