Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call element.on when the merchant passes in a callback #372

Merged
merged 7 commits into from
Jan 10, 2023
Merged

Only call element.on when the merchant passes in a callback #372

merged 7 commits into from
Jan 10, 2023

Commits on Jan 4, 2023

  1. Only attach callbacks the merchant defines

    @awalker-stripe
    awalker-stripe committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    d3285b4 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @awalker-stripe
    awalker-stripe committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    9dfe216 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Adds element as a dependency to useAttachEvent

    @awalker-stripe
    awalker-stripe committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    91d28b4 View commit details
    Browse the repository at this point in the history

  2. Prevent .on and .off from being called on every render

    @awalker-stripe
    awalker-stripe committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    550e7d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Unit test based on repro

    @awalker-stripe
    awalker-stripe committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    f30bee3 View commit details
    Browse the repository at this point in the history

  2. Comment

    @awalker-stripe
    awalker-stripe committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    2caf8f0 View commit details
    Browse the repository at this point in the history

  3. Remove no-op

    @awalker-stripe
    awalker-stripe committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    d055bbe View commit details
    Browse the repository at this point in the history