-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add address element types #352
Conversation
update(options: Partial<StripeAddressElementOptions>): StripeAddressElement; | ||
}; | ||
|
||
export interface ContactOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: should we wait until API review has been gaveled for GA to release this? What is the significance of adding Option
to the name instead of just Contact
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question! I think it should be fine for us to add it now since we want beta users to test it out without running into type error and the whole AE is marked as "beta access" only. I was following the convention we have to append a option
after the type name, such as FieldOption
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one more nit, but otherwise looks good to me, thank you for adding this!
Summary & motivation
Added types for
address
element and markedshippingAddress
as deprecated.Testing & documentation
Added invalid and valid tests