Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyright: fix more type suppressions #1023

Merged
merged 12 commits into from
Aug 24, 2023

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Aug 24, 2023

Fixes type suppressions:

  • Made stripe/__init__.py explicitly define things that were being referenced on it and existed implicitly but weren't picked up by pyright.
  • ListObject/SearchResult types have pagination properties declared.
  • Other sundry fixes.

@richardm-stripe richardm-stripe requested review from a team and anniel-stripe and removed request for a team August 24, 2023 19:17
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

@richardm-stripe richardm-stripe enabled auto-merge (squash) August 24, 2023 20:11
@richardm-stripe richardm-stripe merged commit 1d48f20 into master Aug 24, 2023
10 checks passed
anniel-stripe added a commit that referenced this pull request Aug 24, 2023
* Update generated code (#1016)

* Update generated code for v466

* Update generated code for v468

* Update generated code for v482

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: anniel-stripe <97691964+anniel-stripe@users.noreply.github.com>

* Bump version to 6.1.0

* Pyright: fix more type suppressions (#1023)

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Richard Marmorstein <52928443+richardm-stripe@users.noreply.github.com>
@remi-stripe remi-stripe deleted the richardm-fix-more-suppressions branch September 28, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants