Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modelsToIgnore option #235

Closed
wants to merge 1 commit into from
Closed

Add modelsToIgnore option #235

wants to merge 1 commit into from

Conversation

aquid
Copy link
Contributor

@aquid aquid commented Aug 21, 2016

  • Added a new parameter named as modelsToIgnore which stores a list of models that are to be prevented from being published in loopback angular SDK
  • Added tests for testing modelToIgnore feature

This PR is an update for #224
cc @bajtos @pulkitsinghal

… of models that are to be prevented from being generated and made available through angular

- Added tests for testing modelToIgnore
@slnode
Copy link

slnode commented Aug 21, 2016

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link

slnode commented Aug 21, 2016

Can one of the admins verify this patch?

@aquid
Copy link
Contributor Author

aquid commented Aug 21, 2016

@bajtos Had some rebase issues with the previous PR #224 , so I have updated the commits with new changes and merged it into single commit.

@aquid aquid mentioned this pull request Aug 21, 2016
@bajtos
Copy link
Member

bajtos commented Aug 24, 2016

@slnode ok to test

@bajtos
Copy link
Member

bajtos commented Aug 24, 2016

The Commit Linter failure means your commit message does not follow the 50/27 rule, please fix.

@bajtos bajtos self-assigned this Aug 24, 2016
@bajtos
Copy link
Member

bajtos commented Aug 24, 2016

@aquid other than my comment above, the patch is good to be landed.

@bajtos
Copy link
Member

bajtos commented Aug 24, 2016

I made the changes myself and landed the patch.

Thank you @aquid for your contribution!

@aquid
Copy link
Contributor Author

aquid commented Aug 24, 2016

@bajtos Thanks for your help. It was great learning from this PR and your suggestions helped a lot.

Can you help me with the version number where this change will reflect.

@bajtos
Copy link
Member

bajtos commented Aug 24, 2016

Released loopback-sdk-angular@1.10.0, enjoy :)

aquid added a commit to aquid/grunt-loopback-sdk-angular that referenced this pull request Aug 29, 2016
Since the PR was approved, strongloop/loopback-sdk-angular#235, so updating the version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants