chore: use grunt to optionally install the dependency #3996
Conversation
virkt25
requested review from
bajtos,
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
package.json
Outdated
| "sinon": "^6.1.4", | ||
| "sinon-chai": "^3.2.0", | ||
| "strong-error-handler": "^3.0.0", | ||
| "strong-task-emitter": "^0.0.8", | ||
| "supertest": "^3.0.0" | ||
| }, | ||
| "optionalDependencies": { |
There was a problem hiding this comment.
Please not that optionalDependencies are installed in production, e.g. when an app depends on loopback. With your change in place, every LoopBack application is going to install phantomjs! That would be a poor user experience IMO.
We need to mark phantomjs-prebuilt as an optional dev-dependency instead.
Unfortunately, npm does not support optional dev-dependencies out of the box, at least as far as I can tell from searching the internet and the discussion in npm/npm#3870.
A possible workaround is offered by this npm package https://www.npmjs.com/package/optional-dev-dependency
Considering that we have a single optional dev-dependency only, it may be simpler to simply execute npm install --no-save phantomjs-prebuilt from our Gruntfile. (Maybe check if the package has not been already installed, to speed up repeated execution of npm t for framework developers practicing test-driven development.)
virkt25
changed the title
virkt25
changed the title
connected to #3993
|
@slnode test please |
connected to #3993
Description
Related issues
Checklist
guide