Support AuthenticateWithClaims + local JWT auth in B2B Sessions #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan-stytch
force-pushed
the
logan/go-b2b-jwt
branch
from
b40f54f
to
5306d17
Compare
max-stytch
approved these changes
Oct 4, 2023
stytch/b2b/sessions.go
Outdated
| func (c *SessionsClient) AuthenticateJWT( | ||
| ctx context.Context, | ||
| maxTokenAge time.Duration, | ||
| body *sessions.AuthenticateParams, |
There was a problem hiding this comment.
Let's define a new AuthenticateJWTParams that includes the maxTokenAge in it. Otherwise we break parity with the codegen'd endpoint format, and it makes it harder to add new params in the future. For example, RBAC will be adding a new param to AuthenticateJWT and then we'll be at 4 positional arguments 😢
stytch/b2b/sessions.go
Outdated
| } | ||
| expires = expires.UTC() | ||
|
|
||
| // TODO |
stytch/b2b/sessions_test.go
Outdated
| assert.Equal(t, expected, session) | ||
| }) | ||
|
|
||
| t.Run("valid JWT (old format)", func(t *testing.T) { |
There was a problem hiding this comment.
Do we need to support the old format for B2B?
There was a problem hiding this comment.
We do not! Consequence of copy-pasting tests...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily aims to support local JWT auth in B2B Sessions. Along the way, I had to add support for AuthenticateWithClaims.
The
AuthenticateWithClaimsmethod is autogenerated, which is why you see it popping up nearly everywhere. It gets generated for any function that has aMemberSessionparameter (which happens to be everyAuthenticatemethod).There are a few small docs changes tagging along.