feat: [AUTH-4057] Clean up dependecy on DOM type usage #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
max-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
max-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
logan-stytch
approved these changes
Sep 4, 2024
jbolduc-stytch
approved these changes
Sep 4, 2024
lib/shared/index.ts
Outdated
Comment on lines
46
to
47
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
You can use @ts-expect-error here instead, which has the benefit of introducing an error when/if the line below no longer has an error that needs to be suppressed. (ban-ts-comment is often configured to allow @ts-expect-error + an explanatory comment, to encourage this pattern.)
package.json
Outdated
| @@ -40,14 +40,14 @@ | |||
| "@babel/preset-env": "^7.22.20", | |||
| "@babel/preset-typescript": "^7.23.0", | |||
| "@types/jest": "^29.5.5", | |||
| "@types/node": "^18.18.3", | |||
| "@types/node": "^22.5.1", | |||
There was a problem hiding this comment.
22 isn't LTS yet--I would be inclined to pin this to the oldest major/minor version we still support to reduce the odds we start depending on APIs exclusive to newer versions. (It's imperfect because there could still be breaking API changes in newer versions that we miss, but I think that's less of a risk.)
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DOMintsconfig.json- previously we required all callers to either also haveDOMor to disable library typechecking@types/nodeandtypescriptto latestBodyInittype fromundiciNo runtime code changes are made