feat: add groth16 #1313
Merged
feat: add groth16 #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstam
force-pushed
the
mattstam/groth16
branch
from
d88118e
to
d1e829c
Compare
jtguibas
reviewed
Aug 17, 2024
| @@ -1,8 +1,8 @@ | |||
| # Building PLONK Artifacts | |||
| # Building circuit Artifacts | |||
jtguibas
reviewed
Aug 17, 2024
crates/prover/src/types.rs
Outdated
| pub struct SP1Groth16Bn254ProofData(pub Groth16Bn254Proof); | ||
|
|
||
| #[derive(Serialize, Deserialize, Clone)] | ||
| pub enum SP1ProofData { |
There was a problem hiding this comment.
SP1ProofData is a bit too general.
jtguibas
reviewed
Aug 17, 2024
crates/prover/src/types.rs
Outdated
| } | ||
|
|
||
| impl SP1ProofData { | ||
| pub fn get_proof_system(&self) -> &str { |
There was a problem hiding this comment.
nit: can you use an enum here
jtguibas
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Groth16 to the circuits artifacts generated, and supports generating and verifying proofs for it.
Notes:
~/.sp1/circuits/plonk_bn254/<version>/, they are now stored in~/.sp1/circuits/<version>/, and the full output looks like: