feat: feature flag alloy_sol_types
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
reviewed
May 31, 2024
| pub mod auth; | ||
| #[cfg(feature = "network")] |
There was a problem hiding this comment.
have a network subcrate that you can just feature flag in 1
There was a problem hiding this comment.
To keep the exports the same (i.e. you can import NetworkProver with sp1_sdk::NetworkProver) we still need 2 cfg statements, but I added a network submodule that allows removing the rest of the feature gating.
puma314
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been reports of version incompatibilities between the
alloy_sol_typesversion in thesp1-sdkand those in older versions ofreth.As
alloy_sol_typesis only used by theNetworkProver, add an optional feature flagnetworkwhich can configure out theNetworkProverandalloy_sol_types. This flag is enabled by default, so existing users of the SDK shouldn't see any issues.