Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll menu component #63

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add scroll menu component #63

merged 1 commit into from
Oct 28, 2021

Conversation

luca-rath
Copy link
Contributor

@luca-rath luca-rath commented Oct 28, 2021 •
edited
Loading

This pull request adds a new scroll-menu component. It behaves the same as the scroll-direction component except that it's disabled on top (above the element) and that you can set a tolerance option

@alexander-schranz
Copy link
Member

Would like to have this as own component maybe scroll-menu. I would calculate the offset by the current height of the el of the component.

@luca-rath luca-rath changed the title Enhance scroll direction component Add scroll menu component Oct 28, 2021
@alexander-schranz alexander-schranz merged commit cbd5a78 into sulu:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz left review comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luca-rath @alexander-schranz