Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the documentation for {As,Into,From}Raw{Fd,Handle,Socket} #15

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Update the documentation for {As,Into,From}Raw{Fd,Handle,Socket} #15

merged 1 commit into from
Mar 2, 2022

Conversation

sunfishcode
Copy link
Owner

This ports the changes proposed in rust-lang/rust#93562 to io-lifetimes.

Specifically, remove the redundant comments on
OwnedHandle::from_raw_handle and OwnedSocket::from_raw_socket, and
remove the FromRawHandle impls for HandleOrInvalid and HandleOrNull.

@sunfishcode
Update the documentation for {As,Into,From}Raw{Fd,Handle,Socket}
20ae4da 
This ports the changes proposed in rust-lang/rust#93562 to io-lifetimes.

Specifically, remove the redundant comments on
`OwnedHandle::from_raw_handle` and `OwnedSocket::from_raw_socket`, and
remove the `FromRawHandle` impls for `HandleOrInvalid` and `HandleOrNull`.
@sunfishcode sunfishcode marked this pull request as ready for review March 2, 2022 18:15
@sunfishcode
Copy link
Owner Author

The rust-lang PR is now approved.

@sunfishcode sunfishcode merged commit aaa1794 into main Mar 2, 2022
@sunfishcode sunfishcode deleted the sunfishcode/sync-with-upstream branch March 2, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sunfishcode