Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for io_safety being stabilized. #41

Merged
merged 8 commits into from
Aug 16, 2022
Merged

Update for io_safety being stabilized. #41

merged 8 commits into from
Aug 16, 2022

Commits on Aug 11, 2022

  1. Update for io_safety being stabilized. 

    io_safety is now [stable in Rust 1.63]! This PR updates io-lifetimes to
use the standard library types and traits when available, and use its
own types and traits on older Rust versions.

The traits `FromFd` and `IntoFd` are now marked as deprecated. These are
replaced by `From<OwnedFd>` and `From<...> for OwnedFd` in the standard
library, and users should migrate accordingly.

[stable in Rust 1.63]: https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html#rust-ownership-for-raw-file-descriptorshandles-io-safety
    @sunfishcode
    sunfishcode committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5023e8d View commit details
    Browse the repository at this point in the history

  2. Disable deprecation warnings for our own uses of FromFd and IntoFd. 

    And, migrate the portability types and traits to use `From<OwnedFd>`
and `Into<OwnedFd>`.
    @sunfishcode
    sunfishcode committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    831c21c View commit details
    Browse the repository at this point in the history

  3. Deprecate the from_fd function, rather than the FromFd trait. 

    This allows the `from_into_fd` extension to continue working, for now.
    @sunfishcode
    sunfishcode committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    70caac6 View commit details
    Browse the repository at this point in the history

  4. Fix the --no-default-features build.

    @sunfishcode
    sunfishcode committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3244b09 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. For the IntoFd/etc traits, deprecate the whole trait. 

    This PR isn't deprecating `FromFd` yet, because it provides the
`from_into_fd` utility.
    @sunfishcode
    sunfishcode committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    2a85c7c View commit details
    Browse the repository at this point in the history

  2. Fix broken doc comment links.

    @sunfishcode
    sunfishcode committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c03194f View commit details
    Browse the repository at this point in the history

  3. Fix the from_* deprecation messages.

    @sunfishcode
    sunfishcode committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9a7853b View commit details
    Browse the repository at this point in the history

  4. rustfmt

    @sunfishcode
    sunfishcode committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    3c5f61b View commit details
    Browse the repository at this point in the history