Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces, bug fixes, additional error reason detection #60

Merged
merged 14 commits into from
May 11, 2023
Merged

Add interfaces, bug fixes, additional error reason detection #60

merged 14 commits into from
May 11, 2023

Conversation

wiverson
Copy link
Collaborator

@wiverson wiverson commented May 10, 2023

What kind of change does this PR introduce?

Adds a few of the new methods to the interfaces so they are accessible via the parent supabase-csharp.

Also adds several additional Reasons to help with failures.

What is the current behavior?

A few new methods were only available via the concrete classes, not the interfaces. This means they are not available when using the main supabase client to access (e.g. _supabase.Auth).

What is the new behavior?

Added the missing methods to the interfaces. Also updated the test cases to use the interfaces instead of the concrete implementations to help reduce this error in the future.

Additional context

Builds on the changes from #57

@wiverson
Copy link
Collaborator Author

Sorry, more bug fixes included.

@wiverson wiverson changed the title Add interfaces Add interfaces, bug fixes, additional error reason detection May 11, 2023
@acupofjose acupofjose merged commit 7ccf3ce into supabase-community:master May 11, 2023
@acupofjose
Copy link
Collaborator

Available in 4.0.1 - Thank you!

@wiverson wiverson deleted the add_interface branch May 11, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants