Add compatibility with React 17 and npm 7 #478
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 17 was published in october 2020 (https://github.com/facebook/react/blob/master/CHANGELOG.md#1700-october-20-2020).
npm 7 was published in october 2020 (https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/) and is bundled by default with node 15.
npm 7 changes the way peer dependencies are handled. As a consequence,
connected-react-router
doesn't work with react 17, because thepeerDependency
on React is on^16.4.0
. As a consequence, all packages depending onconnected-react-router
and React 17 cannot be installed with npm 7 (e.g. marmelab/react-admin#5908)I know this is not your repo's fault, and that npm shouldn't have broken BC, but the simple change I propose is an easy fix. So please consider merging it and releasing a new version.
Thanks in advance!