Use code from sbl/scvim #11
Conversation
…fter recompile minor fixes
… create tags to display help
Conditional kill
check for pipe in vim
This reverts commit 955ab2d.
Fix process buildup for ruby 2.3
With this change it should work for old and new versions. Thanks :)
Only check for `scvim` folder
|
Testing it on OS X now, installing it on a clean install of OS X 10.12.2. Will test on RPi tomorrow. Edit: I added the small install issues in a review below instead. |
| DESTINATION /Library/Application\ Support/SuperCollider/Extensions/scvim | ||
| PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ) | ||
| install(FILES sc/SCVim.sc | ||
| DESTINATION /Library/Application\ Support/SuperCollider/Extensions/scvim |
There was a problem hiding this comment.
This installs to system wide Library folder. Should rather be ~/Library/Application\ Support/SuperCollider/Extensions/scvim .
There was a problem hiding this comment.
@blacksound Didn't know that MacOS libraries go into user directory. Will change that.
|
|
||
| def self.sclang_path | ||
| if @@sclang_path.empty? | ||
| if File.exists?("/Applications/SuperCollider.app/Contents/Resources/sclang") |
There was a problem hiding this comment.
Usually when installing SuperCollider from a .dmg people end up with the path: /Applications/SuperCollider/SuperCollider.app/Contents/Resources/sclang.
There was a problem hiding this comment.
This also goes for installing with cmake flag -DINSTALL_PREFIX_PATH=/Applications when building SuperCollider.
There was a problem hiding this comment.
In >= 3.7.2 the location of sclang within the .app file changed. It is now at
/SuperCollider.app/Contents/MacOS/sclang
There was a problem hiding this comment.
@blacksound @brianlheim I have no idea about MacOS... Should it be changed to /Applications/Supercollider.app/Contents/MacOS/sclang? Or maybe check for both paths? (before and after 3.7.2)
ps: this is not related to this PR :) so I'd rather change that later
There was a problem hiding this comment.
I think there are still some people on 3.6.6, so it might be a good idea to check for both paths! I don't have a strong opinion one way or the other, but it should at the very least check the newer path.
There was a problem hiding this comment.
@brianlheim Yeah that seems safer. Do you mind confirming the path for < 3.7.2 and I'll change it right away?
There was a problem hiding this comment.
Yeah sure, the path for sclang is exactly what @blacksound gave above -- SuperCollider.app/Contents/Resources/sclang
There was a problem hiding this comment.
@brianlheim you mean /Applications/SuperCollider/SuperCollider.app/Contents/Resources/sclang right?
There was a problem hiding this comment.
The prefix could be either /Applications/SuperCollider/SuperCollider.app or /Applications/SuperCollider.app depending on how the user performs the installation.
| If your SuperCollider version wasn't build with vim support (i.e. if the class | ||
| `SCVim` does not exist), you'll need to symlink `sc/SCVim.sc` somewhere where | ||
| SuperCollider can find it. Typically that would be in `Platform.userExtensionDir` | ||
| (from within SuperCollider). |
There was a problem hiding this comment.
We could also note that you could add ~/.vim/bundle/scvim/sc to includePaths: in sclang_conf.yaml. Might be easier than making a symlink maybe?
There was a problem hiding this comment.
@blacksound Yeah I will add that, although scvim users probably already know this :)
|
@blacksound @brianlheim pushed your suggested changes |
|
woooooooooo! |
Fix supercollider/supercollider#2550
Fix #7
Re supercollider/supercollider#2652
This replaces (via merging + cleanup) the current master with
sbl/scvimmaster branch and adds a couple of improvements:scvimviavim-plug-DSC_VIMonly installsSCVim.scso users will need to install the vim plugin separatelycc @sbl @carlocapocasa the last 4 commits below are relevant