Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hasher: add input checking, amend helpfile #2589

Merged
merged 2 commits into from
Dec 25, 2016
Merged

Update Hasher: add input checking, amend helpfile #2589

merged 2 commits into from
Dec 25, 2016

Conversation

mossheim
Copy link
Contributor

In response to #2588.

I changed the summary because technically a hash function involves no randomness. I did leave it in the category UGens>Random because that's a pretty good use case; i.e., most people wouldn't actually use this UGen as an actual hashing algorithm.

@nhthn
Copy link
Contributor

nhthn commented Dec 25, 2016

As we discussed, another bug is that Hasher.ar doesn't check the rate of its inputs (Hasher.ar(0) outputs garbage and should be caught at the client). Please add this method:

checkInputs {
    if(rate == \audio) { ^this.checkSameRateAsFirstInput; };
    ^this.checkValidInputs;
}

@nhthn nhthn added the comp: help schelp documentation label Dec 25, 2016
@nhthn nhthn added this to the 3.9 milestone Dec 25, 2016
@mossheim mossheim changed the title Update Hasher.schelp to Update Hasher.schelp Dec 25, 2016
@mossheim
Copy link
Contributor Author

Thanks! Didn't know the fix was that simple.

@mossheim mossheim changed the title Update Hasher.schelp Update Hasher: add input checking, amend helpfile Dec 25, 2016
@telephon telephon merged commit c31a7fb into supercollider:master Dec 25, 2016
@telephon telephon mentioned this pull request Dec 25, 2016
@mossheim mossheim deleted the update-hasher-schelp branch January 16, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: help schelp documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants