Remove potentially unused qt5 dependencies

[simonvanderveldt]

PR to see if these Qt5 dependencies can be removed as discussed in #3471

[scztt]

One request: can we either leave in the Qt5OpenGL dependency, or leave the code but comment it out? Sensors and Positioning are neither here nor there, but there's a decently likelihood that we might start using OpenGL in the future. Cmake is already a hairy beast that very few of the core devs are comfortable modifying, so leaving a breadcrumb trail for this would be helpful.

[mossheim]

I agree, at the very least leave it commented.

Also quick note that this might mean we can remove some dependencies from CI scripts and Readmes

[simonvanderveldt]

Can I conclude based on the passed CI runs that these dependencies are indeed unused?

One request: can we either leave in the Qt5OpenGL dependency, or leave the code but comment it out?

I can comment that one out if that's preferred? I'd say it's in the git history so that wouldn't be needed but it's your codebase :)

Also quick note that this might mean we can remove some dependencies from CI scripts and Readmes

I've found this https://github.com/supercollider/supercollider/blob/develop/.travis/before-install-linux.sh#L9
Qt5OpenGL isn't listed there btw, so I guess that makes it even more clear it wasn't being used.
Is there any other place I need to look at?

[mossheim]

Is there any other place I need to look at?

Nope, just there and then the corresponding place in README_LINUX. The other two OSs use monolithic installs of Qt. Thanks!

[patrickdupuis]

I can update the Linux build guides that are in the Wiki. I think the Rpi and BBB build guides on the website might need to be changed as well.

[mossheim]

ahh, good point

[simonvanderveldt]

@brianlheim @scztt you prefer I comment out the Qt5OpenGL changes instead of removing?
Just checking to be sure.

[mossheim]

yes, thanks for confirming. I get what you're saying about git history but unfortunately on a project this large it's easy for things like that to get lost

[simonvanderveldt]

@brianlheim OK, thanks for the confirmation. I'll update the PR this weekend.

[mossheim]

@simonvanderveldt - can you take another look at this when you get a chance please?

[simonvanderveldt]

@brianlheim Sure, sorry for the radio silence. I'll put in in my agenda for this weekend, is that OK?

[mossheim]

Sure, sorry for the radio silence. I'll put in in my agenda for this weekend, is that OK?

No problem! Just wanted to make sure this doesn't go stale.

[simonvanderveldt]

All right, updated the Qt5OpenGL commit to just comment out (as best as I could) the changes.

Though t.b.h. I'm not sure how much these comments make sense.
Whilst working through this my conclusion was that Qt5OpenGL is just more of the same, anyone looking at the CMakeLists.txt will understand what to add when adding Qt5OpenGL without the comments. For context: I have pretty much zero experience with writing CMakeLists.txt files.

Also removed the qt55sensors install in the Travis setup.

[mossheim]

Thanks!

Though t.b.h. I'm not sure how much these comments make sense.

I understand where you're coming from, but from personal experience not everyone will be able to understand and modify these files as easily as you did. Not really a big deal either way, just trying to give some explanation.

[simonvanderveldt]

Just noticed I forgot to also update LINUX_README, so done that as well :)