Isolate unit tests #3836
Merged
Isolate unit tests #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2018
Closed
mossheim
reviewed
Jul 8, 2018
| @@ -1,56 +1,37 @@ | |||
|
|
|||
| TestUnitTest : UnitTest { | |||
|
|
|||
| var someVar,toreDown,count = 0; | |||
| var someVar, setUp = false, toreDown = false; | |||
There was a problem hiding this comment.
now that we're not testing toreDown, it and tearDown can both be removed from this class
| method = class.findMethod(method.asSymbol); | ||
| if(method.isNil) { Error("Test method not found "+methodName).throw }; | ||
| class.new.runTestMethod(method); | ||
| *runAllTestMethods { |report = true| |
There was a problem hiding this comment.
Should this be a private method? I can't think of a case where using this method directly would be beneficial; it's more or less the same as run(false, report).
|
@brianlheim fixed the issues - thanks for your comments! |
mossheim
suggested changes
Jul 28, 2018
| nil | ||
| }; | ||
|
|
||
| this.deprecated(thisMethod, this.class.findRespondingMethodFor(\run)) |
There was a problem hiding this comment.
should be moved to the deprecations folder
mossheim
approved these changes
Jul 28, 2018
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the UnitTest class and isolates the test methods by making an instance each (replaces #3626) .
This fixes #3572.