fix for issue #3924 (Help Browser executing selected code twice) #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrsurge
changed the title
jrsurge
force-pushed
the
topic/fix-help-double-execute
branch
from
31ad327
to
88406b5
Compare
|
Thanks! Please rebase this against 3.10 -- see our contributor's guide for more information. |
missing else in if-else in HelpBrowser::evaluateSelection()
jrsurge
force-pushed
the
topic/fix-help-double-execute
branch
from
88406b5
to
69b0a2c
Compare
|
rebased and ready for review |
nhthn
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing else in if-else in HelpBrowser::evaluateSelection()
Purpose and Motivation
Fixes #3924
Types of changes
To-do list