Fix ndef as code2 #4695
Merged
Fix ndef as code2 #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
muellmusik
requested changes
Dec 23, 2019
|
(comment: dismissing a review is really disencouraged by the interface, so there is an extra step in such light cases, sorry!) |
muellmusik
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
This is a cleanup PR that replaces #4469, which was cluttered with accediental commits.
Fixes the bug described in #4329, where nodeproxy/Ndef posting as code fails in some cases.
Please read full background in #4469
Types of changes
Bugs fixed
Tests added for all cases
Documentation updated
Code is tested
All tests are passing
Updated documentation
This PR is ready for review