separate affine_t and add some utility to ec/ #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dot-asm
reviewed
Nov 24, 2023
ec/jacobian_t.hpp
Outdated
|
|
||
| #ifndef NDEBUG | ||
| friend inline bool operator==(const jacobian_t& a, const jacobian_t& b) | ||
| { return (a.X == b.X) && (a.Y == b.Y) && (a.Z == b.Z); } |
There was a problem hiding this comment.
This is not how you compare points in Jacobian coordinates for equality. See POINT_IS_EQUAL_IMPL for a template. Same naturally applies to the inequality test, which should read just !(a == b). Or maybe compiler does it for you without having to define operator!=?
There was a problem hiding this comment.
This is not how you compare points in Jacobian coordinates for equality.
Right, same thing with xyzz_t. I'll fix both.
There was a problem hiding this comment.
Should be fixed now for both jacobian_t and xyzz_t, thanks! I also removed __device__ from == and != because I realised mont_t didn't have them and thought it would be better to leave it to a later time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be backwards compatible.