Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asynchronously instantiate components when using Svelte 5 #12613

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

dummdidumm
Copy link
Member

Adjusts the behavior to that of the new mount/hydrate APIs and also fixes #12248

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Adjusts the behavior to that of the new `mount`/`hydrate` APIs and also fixes #12248
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: efba064

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

hydrate
hydrate,
// @ts-ignore Svelte 5 specific
sync: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the PR title I wasn't sure if this mean sync as in sync/async or as in mirror data. It's also a little funny that it needs to be set it to false. Maybe the API should be something like asynchronous: true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go either way, but I'd go with what we have; this doesn't need to be great in terms of design, it's somewhat of an internal and temporary thing anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pushHistory throws an error when used inside a $effect hook
3 participants