-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: asynchronously instantiate components when using Svelte 5 #12613
Conversation
Adjusts the behavior to that of the new `mount`/`hydrate` APIs and also fixes #12248
🦋 Changeset detectedLatest commit: efba064 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hydrate | ||
hydrate, | ||
// @ts-ignore Svelte 5 specific | ||
sync: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without the PR title I wasn't sure if this mean sync
as in sync
/async
or as in mirror data. It's also a little funny that it needs to be set it to false
. Maybe the API should be something like asynchronous: true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can go either way, but I'd go with what we have; this doesn't need to be great in terms of design, it's somewhat of an internal and temporary thing anyway.
Adjusts the behavior to that of the new
mount
/hydrate
APIs and also fixes #12248Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits